Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/testbed-support: add nrf52{840,832}mdk in IOTLAB_NODE targets #12395

Merged
merged 2 commits into from
Oct 16, 2019
Merged

dist/testbed-support: add nrf52{840,832}mdk in IOTLAB_NODE targets #12395

merged 2 commits into from
Oct 16, 2019

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Oct 8, 2019

Contribution description

While debugging #12394, I was surprised when I realized that nrf52840-mdk was not in the list of iotlab supported boards.

This PR fixes that.

Testing procedure

  • Start an experiment on (the only) nrf52840-mdk board in iotlab:
$ iotlab-experiment submit -n "" -d 60 -l saclay,nrf52840mdk,1
  • Verify that you can flash it and get a terminal:
$ make BOARD=nrf52840-mdk IOTLAB_NODE=auto-ssh -C examples/hello-world flash term

Note: this doesn't work without #12394

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 8, 2019
@aabadie aabadie requested a review from fjmolinas October 8, 2019 12:38
@aabadie aabadie changed the title dist/testbed-support: add nrf5840mdk in IOTLAB_NODE targets dist/testbed-support: add nrf52840mdk in IOTLAB_NODE targets Oct 8, 2019
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Oct 8, 2019
@aabadie aabadie force-pushed the pr/dist/testbed-support-add-nrf52840-mdk branch from 0dc6b6e to b389b88 Compare October 8, 2019 18:10
@aabadie aabadie mentioned this pull request Oct 16, 2019
Merged
@fjmolinas
Copy link
Contributor

Hmm somehow this is not working for me for nrf52832-mdk:

IOTLAB_EXP_ID=180254 make BOARD=nrf52832-mdk IOTLAB_NODE=auto-ssh -C examples/hello-world flash
make: Entering directory '/home/francisco/workspace/RIOT-test/examples/hello-world'
/home/francisco/workspace/RIOT-test/dist/testbed-support/makefile.iotlab.single.inc.mk:109: *** Could not automatically find a node for BOARD=nrf52832-mdk.  Stop.
make: Leaving directory '/home/francisco/workspace/RIOT-test/examples/hello-world'

I have correctly reserved the experiment though:

iotlab-experiment get -i 180254 -r
        {
            "archi": "nrf52832mdk:ble",
            "mobile": "0",
            "mobility_type": " ",
            "network_address": "nrf52832mdk-1.saclay.iot-lab.info",
            "site": "saclay",
            "state": "Alive",
            "uid": " ",
            "x": "1",
            "y": "68.3",
            "z": "4"
        },

Am I missing something?

@aabadie aabadie force-pushed the pr/dist/testbed-support-add-nrf52840-mdk branch from c663c27 to bdd3fed Compare October 16, 2019 09:57
@aabadie
Copy link
Contributor Author

aabadie commented Oct 16, 2019

Am I missing something?

There was a small mistake. It's fixed now.

@aabadie
Copy link
Contributor Author

aabadie commented Oct 16, 2019

(I had to stop your experiment on IoT-LAB, sorry ;) )

fjmolinas
fjmolinas approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can flash on both boards once rebase on #12394

IOTLAB_EXP_ID=180302 make BOARD=nrf52832-mdk IOTLAB_NODE=auto-ssh -C examples/hello-world flash-only
make: Entering directory '/home/francisco/workspace/RIOT-test/examples/hello-world'
iotlab-node --jmespath='keys(@)[0]' --format='int' --id 180302 --list saclay,nrf52832mdk,1 --update /home/francisco/workspace/RIOT-test/examples/hello-world/bin/nrf52832-mdk/hello-world.elf | grep 0
0
make: Leaving directory '/home/francisco/workspace/RIOT-test/examples/hello-world'

IOTLAB_EXP_ID=180302 make BOARD=nrf52840-mdk IOTLAB_NODE=auto-ssh -C examples/hello-world flash-only
make: Entering directory '/home/francisco/workspace/RIOT-test/examples/hello-world'
iotlab-node --jmespath='keys(@)[0]' --format='int' --id 180302 --list saclay,nrf52840mdk,1 --update /home/francisco/workspace/RIOT-test/examples/hello-world/bin/nrf52840-mdk/hello-world.elf | grep 0
0
make: Leaving directory '/home/francisco/workspace/RIOT-test/examples/hello-world'

@aabadie aabadie changed the title dist/testbed-support: add nrf52840mdk in IOTLAB_NODE targets dist/testbed-support: add nrf52{840,832}mdk in IOTLAB_NODE targets Oct 16, 2019
@fjmolinas
Copy link
Contributor

GO!

@fjmolinas fjmolinas merged commit 02ae803 into RIOT-OS:master Oct 16, 2019
@aabadie aabadie deleted the pr/dist/testbed-support-add-nrf52840-mdk branch October 16, 2019 13:59
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @fjmolinas @miri64